From f20ebd5bdd1a52f3824048cd9bb1145c714623e2 Mon Sep 17 00:00:00 2001
From: Sebastien Castiel <sebastien@castiel.me>
Date: Wed, 10 Jan 2024 08:21:12 -0500
Subject: [PATCH] Improve design for expense list

---
 .../[groupId]/expenses/expense-list.tsx       | 28 ++++++++++++-------
 src/app/groups/[groupId]/expenses/page.tsx    |  6 ++--
 2 files changed, 21 insertions(+), 13 deletions(-)

diff --git a/src/app/groups/[groupId]/expenses/expense-list.tsx b/src/app/groups/[groupId]/expenses/expense-list.tsx
index 4578300..3fae873 100644
--- a/src/app/groups/[groupId]/expenses/expense-list.tsx
+++ b/src/app/groups/[groupId]/expenses/expense-list.tsx
@@ -48,20 +48,20 @@ export function ExpenseList({
       <div
         key={expense.id}
         className={cn(
-          'border-t flex justify-between pl-6 pr-2 py-4 text-sm cursor-pointer hover:bg-accent gap-1',
+          'border-t flex justify-between px-4 sm:pr-2 sm:pl-6 py-4 text-sm cursor-pointer hover:bg-accent gap-1 items-stretch',
           expense.isReimbursement && 'italic',
         )}
         onClick={() => {
           router.push(`/groups/${groupId}/expenses/${expense.id}/edit`)
         }}
       >
-        <div>
+        <div className="flex-1">
           <div className={cn('mb-1', expense.isReimbursement && 'italic')}>
             {expense.title}
           </div>
           <div className="text-xs text-muted-foreground">
-            Paid by <strong>{getParticipant(expense.paidById)?.name}</strong> on{' '}
-            {formatDate(expense.expenseDate)} for{' '}
+            Paid by <strong>{getParticipant(expense.paidById)?.name}</strong>{' '}
+            for{' '}
             {expense.paidFor.map((paidFor, index) => (
               <Fragment key={index}>
                 {index !== 0 && <>, </>}
@@ -75,7 +75,7 @@ export function ExpenseList({
             ))}
           </div>
         </div>
-        <div className="flex items-center">
+        <div className="flex flex-col justify-between items-end">
           <div
             className={cn(
               'tabular-nums whitespace-nowrap',
@@ -84,12 +84,20 @@ export function ExpenseList({
           >
             {currency} {(expense.amount / 100).toFixed(2)}
           </div>
-          <Button size="icon" variant="link" className="-my-2" asChild>
-            <Link href={`/groups/${groupId}/expenses/${expense.id}/edit`}>
-              <ChevronRight className="w-4 h-4" />
-            </Link>
-          </Button>
+          <div className="text-xs text-muted-foreground">
+            {formatDate(expense.expenseDate)}
+          </div>
         </div>
+        <Button
+          size="icon"
+          variant="link"
+          className="self-center hidden sm:flex"
+          asChild
+        >
+          <Link href={`/groups/${groupId}/expenses/${expense.id}/edit`}>
+            <ChevronRight className="w-4 h-4" />
+          </Link>
+        </Button>
       </div>
     ))
   ) : (
diff --git a/src/app/groups/[groupId]/expenses/page.tsx b/src/app/groups/[groupId]/expenses/page.tsx
index 2a1ac5f..c9b5a8a 100644
--- a/src/app/groups/[groupId]/expenses/page.tsx
+++ b/src/app/groups/[groupId]/expenses/page.tsx
@@ -30,15 +30,15 @@ export default async function GroupExpensesPage({
 
   return (
     <>
-      <Card className="mb-4">
+      <Card className="mb-4 rounded-none -mx-4 border-x-0 sm:border-x sm:rounded-lg sm:mx-0">
         <div className="flex flex-1">
-          <CardHeader className="flex-1">
+          <CardHeader className="flex-1 p-4 sm:p-6">
             <CardTitle>Expenses</CardTitle>
             <CardDescription>
               Here are the expenses that you created for your group.
             </CardDescription>
           </CardHeader>
-          <CardHeader>
+          <CardHeader className="p-4 sm:p-6">
             <Button asChild size="icon">
               <Link href={`/groups/${groupId}/expenses/create`}>
                 <Plus />