mirror of
https://github.com/JetBrains/JetBrainsRuntime.git
synced 2025-12-06 09:29:38 +01:00
JBR-4563 Rounded corners for native Window on Mac OS
This commit is contained in:
@@ -107,6 +107,7 @@ public class CPlatformWindow extends CFRetainedResource implements PlatformWindo
|
||||
private static native boolean nativeDelayShowing(long nsWindowPtr);
|
||||
private static native void nativeSetTransparentTitleBarHeight(long nsWindowPtr, float height);
|
||||
private static native void nativeCallDeliverMoveResizeEvent(long nsWindowPtr);
|
||||
private static native void nativeSetRoundedCorners(long nsWindowPrt, float radius);
|
||||
|
||||
// Logger to report issues happened during execution but that do not affect functionality
|
||||
private static final PlatformLogger logger = PlatformLogger.getLogger("sun.lwawt.macosx.CPlatformWindow");
|
||||
@@ -140,6 +141,7 @@ public class CPlatformWindow extends CFRetainedResource implements PlatformWindo
|
||||
public static final String WINDOW_TITLE_VISIBLE = "apple.awt.windowTitleVisible";
|
||||
public static final String WINDOW_APPEARANCE = "apple.awt.windowAppearance";
|
||||
public static final String WINDOW_TRANSPARENT_TITLE_BAR_HEIGHT = "apple.awt.windowTransparentTitleBarHeight";
|
||||
public static final String WINDOW_CORNER_RADIUS = "apple.awt.windowCornerRadius";
|
||||
|
||||
// This system property is named as jdk.* because it is not specific to AWT
|
||||
// and it is also used in JavaFX
|
||||
@@ -299,6 +301,13 @@ public class CPlatformWindow extends CFRetainedResource implements PlatformWindo
|
||||
c.execute(ptr -> AWTThreading.executeWaitToolkit(wait -> nativeSetTransparentTitleBarHeight(ptr, (float) value)));
|
||||
}
|
||||
}
|
||||
},
|
||||
new Property<CPlatformWindow>(WINDOW_CORNER_RADIUS) {
|
||||
public void applyProperty(final CPlatformWindow c, final Object value) {
|
||||
if (value != null && (value instanceof Float)) {
|
||||
c.execute(ptr -> nativeSetRoundedCorners(ptr, (float) value));
|
||||
}
|
||||
}
|
||||
}
|
||||
}) {
|
||||
@SuppressWarnings("deprecation")
|
||||
|
||||
@@ -2384,3 +2384,24 @@ JNIEXPORT void JNICALL Java_sun_lwawt_macosx_CPlatformWindow_nativeCallDeliverMo
|
||||
|
||||
JNI_COCOA_EXIT(env);
|
||||
}
|
||||
|
||||
JNIEXPORT void JNICALL Java_sun_lwawt_macosx_CPlatformWindow_nativeSetRoundedCorners
|
||||
(JNIEnv *env, jclass clazz, jlong windowPtr, jfloat radius)
|
||||
{
|
||||
JNI_COCOA_ENTER(env);
|
||||
|
||||
NSWindow *w = (NSWindow *)jlong_to_ptr(windowPtr);
|
||||
[ThreadUtilities performOnMainThreadWaiting:NO block:^(){
|
||||
w.hasShadow = YES;
|
||||
w.contentView.wantsLayer = YES;
|
||||
w.contentView.layer.cornerRadius = radius;
|
||||
w.contentView.layer.masksToBounds = YES;
|
||||
w.backgroundColor = NSColor.clearColor;
|
||||
w.opaque = NO;
|
||||
// remove corner radius animation
|
||||
[w.contentView.layer removeAllAnimations];
|
||||
[w invalidateShadow];
|
||||
}];
|
||||
|
||||
JNI_COCOA_EXIT(env);
|
||||
}
|
||||
|
||||
161
test/jdk/jb/java/awt/Window/MacNativeSetRoundedCorners.java
Normal file
161
test/jdk/jb/java/awt/Window/MacNativeSetRoundedCorners.java
Normal file
@@ -0,0 +1,161 @@
|
||||
/*
|
||||
* Copyright 2022 JetBrains s.r.o.
|
||||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
|
||||
*
|
||||
* This code is free software; you can redistribute it and/or modify it
|
||||
* under the terms of the GNU General Public License version 2 only, as
|
||||
* published by the Free Software Foundation.
|
||||
*
|
||||
* This code is distributed in the hope that it will be useful, but WITHOUT
|
||||
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
||||
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
|
||||
* version 2 for more details (a copy is included in the LICENSE file that
|
||||
* accompanied this code).
|
||||
*
|
||||
* You should have received a copy of the GNU General Public License version
|
||||
* 2 along with this work; if not, write to the Free Software Foundation,
|
||||
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
|
||||
*
|
||||
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
|
||||
* or visit www.oracle.com if you need additional information or have any
|
||||
* questions.
|
||||
*/
|
||||
|
||||
import javax.swing.*;
|
||||
import java.awt.*;
|
||||
import java.awt.image.BufferedImage;
|
||||
import java.lang.reflect.InvocationTargetException;
|
||||
|
||||
/**
|
||||
* @test
|
||||
* @key headful
|
||||
* @summary JBR-4563 Rounded corners for native Window on Mac OS
|
||||
* @author Alexander Lobas
|
||||
* @run main MacNativeSetRoundedCorners
|
||||
* @requires (os.family == "mac")
|
||||
*/
|
||||
public class MacNativeSetRoundedCorners {
|
||||
private static final int TD = 10;
|
||||
private static final int DELAY = 1000;
|
||||
|
||||
private static MacNativeSetRoundedCorners theTest;
|
||||
|
||||
private final Robot robot;
|
||||
private JFrame frame;
|
||||
private JFrame testFrame;
|
||||
|
||||
public MacNativeSetRoundedCorners() {
|
||||
try {
|
||||
robot = new Robot();
|
||||
} catch (AWTException ex) {
|
||||
throw new RuntimeException(ex);
|
||||
}
|
||||
}
|
||||
|
||||
public void performTest() {
|
||||
runSwing(() -> {
|
||||
frame = new JFrame("");
|
||||
frame.setUndecorated(true);
|
||||
JPanel panel = new JPanel();
|
||||
panel.setOpaque(true);
|
||||
panel.setBackground(Color.RED);
|
||||
frame.setContentPane(panel);
|
||||
frame.setBounds(100, 100, 300, 300);
|
||||
frame.setVisible(true);
|
||||
|
||||
testFrame = new JFrame("");
|
||||
testFrame.setUndecorated(true);
|
||||
JPanel testPanel = new JPanel();
|
||||
testPanel.setOpaque(true);
|
||||
testPanel.setBackground(Color.GREEN);
|
||||
testFrame.setContentPane(testPanel);
|
||||
testFrame.setBounds(150, 150, 50, 50);
|
||||
testFrame.setVisible(true);
|
||||
});
|
||||
|
||||
robot.delay(DELAY);
|
||||
|
||||
// check that window without rounded corners
|
||||
validateColor(51, 51, Color.GREEN, "0");
|
||||
validateColor(51, 99, Color.GREEN, "0");
|
||||
validateColor(99, 51, Color.GREEN, "0");
|
||||
validateColor(99, 99, Color.GREEN, "0");
|
||||
|
||||
runSwing(() -> testFrame.setVisible(false));
|
||||
robot.delay(DELAY);
|
||||
|
||||
runSwing(() -> {
|
||||
testFrame.getRootPane().putClientProperty("apple.awt.windowCornerRadius", Float.valueOf(10));
|
||||
testFrame.setVisible(true);
|
||||
});
|
||||
robot.delay(DELAY);
|
||||
|
||||
// check that window with rounded corners
|
||||
validateColor(51, 51, Color.RED, "1");
|
||||
validateColor(51, 99, Color.RED, "1");
|
||||
validateColor(99, 51, Color.RED, "1");
|
||||
validateColor(99, 99, Color.RED, "1");
|
||||
|
||||
runSwing(() -> dispose());
|
||||
}
|
||||
|
||||
private Color getTestPixel(int x, int y) {
|
||||
Rectangle bounds = frame.getBounds();
|
||||
BufferedImage screenImage = robot.createScreenCapture(bounds);
|
||||
int rgb = screenImage.getRGB(x, y);
|
||||
int red = (rgb >> 16) & 0xFF;
|
||||
int green = (rgb >> 8) & 0xFF;
|
||||
int blue = rgb & 0xFF;
|
||||
return new Color(red, green, blue);
|
||||
}
|
||||
|
||||
private static boolean validateColor(Color actual, Color expected) {
|
||||
return Math.abs(actual.getRed() - expected.getRed()) <= TD &&
|
||||
Math.abs(actual.getGreen() - expected.getGreen()) <= TD &&
|
||||
Math.abs(actual.getBlue() - expected.getBlue()) <= TD;
|
||||
}
|
||||
|
||||
private void validateColor(int x, int y, Color expected, String place) {
|
||||
Color actual = getTestPixel(x, y);
|
||||
if (!validateColor(actual, expected)) {
|
||||
throw new RuntimeException(
|
||||
"Test failed [" + place + "]. Incorrect color " + actual + " instead " + expected + " at (" + x + "," + y + ")");
|
||||
}
|
||||
}
|
||||
|
||||
private static void runSwing(Runnable r) {
|
||||
try {
|
||||
SwingUtilities.invokeAndWait(r);
|
||||
} catch (InterruptedException e) {
|
||||
} catch (InvocationTargetException e) {
|
||||
throw new RuntimeException(e);
|
||||
}
|
||||
}
|
||||
|
||||
public void dispose() {
|
||||
if (frame != null) {
|
||||
frame.dispose();
|
||||
frame = null;
|
||||
}
|
||||
if (testFrame != null) {
|
||||
testFrame.dispose();
|
||||
testFrame = null;
|
||||
}
|
||||
}
|
||||
|
||||
public static void main(String[] args) {
|
||||
if (!System.getProperty("os.name").contains("OS X")) {
|
||||
System.out.println("This test is for MacOS only. Automatically passed on other platforms.");
|
||||
return;
|
||||
}
|
||||
|
||||
try {
|
||||
runSwing(() -> theTest = new MacNativeSetRoundedCorners());
|
||||
theTest.performTest();
|
||||
} finally {
|
||||
if (theTest != null) {
|
||||
runSwing(() -> theTest.dispose());
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user