mirrors/JetBrainsRuntime
1
0
Fork 0
mirror of https://github.com/JetBrains/JetBrainsRuntime.git synced 2025-12-06 09:29:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

JBR-8358 Vulkan: Framebuffer destruction queue

Browse Source 
Can be generalized to destroy arbitrary resources later.
This commit is contained in:
Nikita Gubarkov
2025-03-03 17:55:19 +01:00
parent e957e7045e
commit 224ccc0fb8
1 changed files with 19 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/java.desktop/share/native/common/java2d/vulkan/VKRenderer.c
View File

@@ -96,6 +96,7 @@ struct VKRenderer {
POOL(VkSemaphore, semaphorePool);
POOL(VKBuffer, vertexBufferPool);
POOL(VKTexelBuffer, maskFillBufferPool);
POOL(VkFramebuffer, framebufferDestructionQueue);
ARRAY(VKMemory) bufferMemoryPages;
ARRAY(VkDescriptorPool) descriptorPools;
@@ -342,6 +343,9 @@ void VKRenderer_Destroy(VKRenderer* renderer) {
device->vkDestroyBufferView(device->handle, entry->value.view, NULL);
device->vkDestroyBuffer(device->handle, entry->value.buffer.handle, NULL);
}
POOL_DRAIN_FOR(renderer, framebufferDestructionQueue, entry) {
device->vkDestroyFramebuffer(device->handle, entry->value, NULL);
}
for (uint32_t i = 0; i < ARRAY_SIZE(renderer->bufferMemoryPages); i++) {
VKAllocator_Free(device->allocator, renderer->bufferMemoryPages[i]);
}
@@ -362,6 +366,17 @@ void VKRenderer_Destroy(VKRenderer* renderer) {
free(renderer);
}
static void VKRenderer_CleanupPendingResources(VKRenderer* renderer) {
VKDevice* device = renderer->device;
for (;;) {
VkFramebuffer framebuffer = VK_NULL_HANDLE;
POOL_TAKE(renderer, framebufferDestructionQueue, framebuffer);
if (framebuffer == VK_NULL_HANDLE) break;
device->vkDestroyFramebuffer(device->handle, framebuffer, NULL);
J2dRlsTraceLn1(J2D_TRACE_VERBOSE, "VKRenderer_CleanupPendingResources(%p): framebuffer destroyed", renderer);
}
}
/**
* Record commands into primary command buffer (outside of a render pass).
* Recorded commands will be sent for execution via VKRenderer_Flush.
@@ -399,6 +414,7 @@ VkCommandBuffer VKRenderer_Record(VKRenderer* renderer) {
void VKRenderer_Flush(VKRenderer* renderer) {
if (renderer == NULL) return;
VKRenderer_CleanupPendingResources(renderer);
VKDevice* device = renderer->device;
size_t pendingPresentations = ARRAY_SIZE(renderer->pendingPresentation.swapchains);
@@ -558,6 +574,7 @@ void VKRenderer_DestroyRenderPass(VKSDOps* surface) {
if (device != NULL && device->renderer != NULL) {
// Wait while surface resources are being used by the device.
VKRenderer_Wait(device->renderer, surface->renderPass->lastTimestamp);
VKRenderer_CleanupPendingResources(device->renderer);
VKRenderer_DiscardRenderPass(surface);
// Release resources.
device->vkDestroyFramebuffer(device->handle, surface->renderPass->framebuffer, NULL);
@@ -619,8 +636,8 @@ static void VKRenderer_InitFramebuffer(VKSDOps* surface) {
VKRenderPass* renderPass = surface->renderPass;
if (renderPass->currentStencilMode == STENCIL_MODE_NONE && surface->stencil != NULL) {
// Destroy outdated color-only framebuffer.
device->vkDestroyFramebuffer(device->handle, renderPass->framebuffer, NULL);
// Queue outdated color-only framebuffer for destruction.
POOL_RETURN(device->renderer, framebufferDestructionQueue, renderPass->framebuffer);
renderPass->framebuffer = VK_NULL_HANDLE;
renderPass->currentStencilMode = STENCIL_MODE_OFF;
}