8308935: jdk.management.jfr.RecordingInfo.toString() lacks test coverage

Reviewed-by: mgronlun
(cherry picked from commit 77c5adb09e)
This commit is contained in:
Erik Gahlin
2023-05-26 16:00:12 +00:00
committed by Vitaly Provodin
parent dc4ef0f0e8
commit 7372da0fe2

View File

@@ -35,6 +35,7 @@ import jdk.jfr.RecordingState;
import jdk.management.jfr.FlightRecorderMXBean;
import jdk.management.jfr.RecordingInfo;
import jdk.test.lib.jfr.CommonHelper;
import jdk.test.lib.Asserts;
/**
* @test
@@ -62,6 +63,16 @@ public class TestRecordingInfo {
FlightRecorderMXBean bean = JmxHelper.getFlighteRecorderMXBean();
RecordingInfo info = JmxHelper.verifyExists(recording.getId(), bean.getRecordings());
String text = info.toString();
assertContains(text, "name");
assertContains(text, String.valueOf(info.getName()));
assertContains(text, "id");
assertContains(text, String.valueOf(info.getId()));
assertContains(text, "maxAge");
assertContains(text, String.valueOf(info.getMaxAge()));
assertContains(text, "maxSize");
assertContains(text, String.valueOf(info.getMaxSize()));
System.out.println(JmxHelper.asString(recording));
System.out.println(JmxHelper.asString(info));
JmxHelper.verifyEquals(info, recording);
@@ -70,4 +81,9 @@ public class TestRecordingInfo {
recording.close();
}
private static void assertContains(String text, String match) {
if (!text.contains(match)) {
Asserts.fail("Expected '" + text + "' to contain '" + match + '"');
}
}
}