mirrors/JetBrainsRuntime
1
0
Fork 0
mirror of https://github.com/JetBrains/JetBrainsRuntime.git synced 2025-12-06 09:29:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

8333366: C2: CmpU3Nodes are not pushed back to worklist in PhaseCCP leading to non-fixpoint assertion failure

Browse Source 
Reviewed-by: kvn, thartmann
This commit is contained in:
Christian Hagedorn
2024-06-03 06:41:33 +00:00
parent 75220da26f
commit 7c83d7ab53
2 changed files with 53 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/hotspot/share/opto/phaseX.cpp
View File

@@ -1921,8 +1921,9 @@ void PhaseCCP::push_cmpu(Unique_Node_List& worklist, const Node* use) const {
if (use_op == Op_AddI || use_op == Op_SubI) {
for (DUIterator_Fast imax, i = use->fast_outs(imax); i < imax; i++) {
Node* cmpu = use->fast_out(i);
if (cmpu->Opcode() == Op_CmpU) {
// Got a CmpU which might need the new type information from node n.
const uint cmpu_opcode = cmpu->Opcode();
if (cmpu_opcode == Op_CmpU || cmpu_opcode == Op_CmpU3) {
// Got a CmpU or CmpU3 which might need the new type information from node n.
push_if_not_bottom_type(worklist, cmpu);
}
}

50
test/hotspot/jtreg/compiler/ccp/TestPushCmpU3Node.java Normal file
View File

@@ -0,0 +1,50 @@
/*
* Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/*
* @test
* @bug 8333366
* @summary Test that CmpU3Nodes are pushed back to the CCP worklist such that the type can be re-evaluated.
* @run main/othervm -Xbatch -XX:CompileCommand=compileonly,*TestPushCmpU3Node::test
* compiler.ccp.TestPushCmpU3Node
*/
package compiler.ccp;
import static java.lang.Integer.*;
public class TestPushCmpU3Node {
public static void main(String[] args) {
for (int i = 0; i < 10_000; ++i) {
test();
}
}
public static void test() {
for (int i = MAX_VALUE - 50_000; compareUnsigned(i, -1) < 0; ++i) {
if (compareUnsigned(MIN_VALUE, i) < 0) {
return;
}
}
}
}