mirrors/JetBrainsRuntime
1
0
Fork 0
mirror of https://github.com/JetBrains/JetBrainsRuntime.git synced 2025-12-06 09:29:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

JBR-2934 Serious usability issue with GoLand 2020.3 caused by JBR

Browse Source 
(cherry picked from commit 95be4351d4)
This commit is contained in:
Dmitry Batrak
2020-12-28 20:37:55 +03:00
committed by Vitaly Provodin
parent 06c43c698d
commit e3bd483d6d
1 changed files with 21 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
src/java.desktop/unix/classes/sun/awt/X11/XWindowPeer.java
View File

@@ -1095,26 +1095,29 @@ class XWindowPeer extends XPanelPeer implements WindowPeer,
}
}
/*
* This decides on a mechanism to suppress newly created window from getting
* focus, if 'autoRequestFocus' is set to 'false'. The 'old' (historically
* used) way is to suppress WM_TAKE_FOCUS protocol temporarily, until the
* window is mapped. This approach doesn't work for i3 window manager
* though, as the latter doesn't track updates to WM_TAKE_FOCUS property
* (it's not required as per ICCCM specification). So another approach is
* used - setting _NET_WM_USER_TIME to 0, as specified in EWMH spec (see
* 'setUserTimeBeforeShowing' method). The same method is used currently for
* KDE (KWin) to solve a specific problem in 'focus follows mouse' mode
* (JBR-2934). Ideally, the new approach should be used for all supporting
* window managers, as it doesn't require additional calls to X server.
*/
private boolean shouldSuppressWmTakeFocus() {
int wmId = XWM.getWMID();
return wmId != XWM.I3_WM && wmId != XWM.KDE2_WM;
}
public void setVisible(boolean vis) {
if (!isVisible() && vis) {
isBeforeFirstMapNotify = true;
winAttr.initialFocus = isAutoRequestFocus();
if (!winAttr.initialFocus && XWM.getWMID() != XWM.I3_WM) {
/*
* It's easier and safer to temporary suppress WM_TAKE_FOCUS
* protocol itself than to ignore WM_TAKE_FOCUS client message.
* Because we will have to make the difference between
* the message come after showing and the message come after
* activation. Also, on Metacity, for some reason, we have _two_
* WM_TAKE_FOCUS client messages when showing a frame/dialog.
*
* i3 window manager doesn't track updates to WM_TAKE_FOCUS
* property, so this approach won't work for it, breaking
* focus behaviour completely. So another way is used to
* suppress focus take over - via setting _NET_WM_USER_TIME
* to 0, as specified in EWMH spec (see
* 'setUserTimeBeforeShowing' method).
*/
if (!winAttr.initialFocus && shouldSuppressWmTakeFocus()) {
suppressWmTakeFocus(true);
}
}
@@ -1192,7 +1195,7 @@ class XWindowPeer extends XPanelPeer implements WindowPeer,
@Override
void setUserTimeBeforeShowing() {
if (winAttr.initialFocus || XWM.getWMID() != XWM.I3_WM) {
if (winAttr.initialFocus || shouldSuppressWmTakeFocus()) {
super.setUserTimeBeforeShowing();
}
else {
@@ -1439,7 +1442,7 @@ class XWindowPeer extends XPanelPeer implements WindowPeer,
isUnhiding |= isWMStateNetHidden();
super.handleMapNotifyEvent(xev);
if (!winAttr.initialFocus && XWM.getWMID() != XWM.I3_WM) {
if (!winAttr.initialFocus && shouldSuppressWmTakeFocus()) {
suppressWmTakeFocus(false); // restore the protocol.
/*
* For some reason, on Metacity, a frame/dialog being shown